Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setters to builders #12

Closed
MaxOhn opened this issue May 21, 2024 · 0 comments · Fixed by #14
Closed

Add setters to builders #12

MaxOhn opened this issue May 21, 2024 · 0 comments · Fixed by #14

Comments

@MaxOhn
Copy link
Owner

MaxOhn commented May 21, 2024

As mentioned in #11, the classes Performance, Difficulty, and BeatmapAttributesBuilder should have setter methods to adjust their fields.

This might lead users to initialize each field with setters instead of using the more efficient constructor but that's a worthy tradeoff considering that there's currently no way to re-use a builder with just a single field modified for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant