-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Ads API #499
Comments
Hello Dave! |
@davecardwell I've included googleads API to the CI. And opened PRs to add it to DT. |
@Maxim-Mazurok awesome turnaround, thank you. I honestly can’t remember where I found the discovery doc originally, sorry! |
@davecardwell https://www.npmjs.com/package/@types/gapi.client.googleads just got published, feel free to replace |
@davecardwell Hello Dave, I see that the current Google Ads API version is 11, and we're still only publishing types for version 7... I'm working on multiple versions support for #652 and just wanted to confirm with you that you are/were using Google Ads on the client-side (front-end)? |
@davecardwell I finally managed to make Google Ads API work on the client using Still can't make it work using |
@Maxim-Mazurok I was using it on the front-end. Unfortunately I don’t recall the exact method and I have moved on from that company so no longer have access to the project to check. |
I see, thanks anyway for confirming, since it can be used on FE - I'll make sure we keep on generating types for it, cheers! |
The Google Ads API has a discovery document available but it is not listed in the googleapis.com API list for some reason.
I can generate the types manually using
npm start -- --url https://googleads.googleapis.com/\\\$discovery/rest?version=v7
but couldn’t see any way of adding it to the automated generating/linting/testing/publishing pipeline.For APIs that are not listed in the API list am I best off adding directly to DefinitelyTyped or is there a simple way to support hard-coded discovery doc URLs in this project?
The text was updated successfully, but these errors were encountered: