Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Dir option not observed/saved #169

Closed
mfeemster opened this issue Jun 2, 2015 · 6 comments
Closed

Sync Dir option not observed/saved #169

mfeemster opened this issue Jun 2, 2015 · 6 comments

Comments

@mfeemster
Copy link

When running "ConEmu Inside", there is an option to keep the folders in sync with "Sync Dir".

Selecting this, clicking register, and clicking save settings does not actually save the setting. Sync Dir will only enabled for that session/folder. Running ConEmu Inside in another window will not have Sync Dir enabled, forcing the user to set it every time.

Repro steps:

Run ConEmu Inside, click settings
Select Sync Dir
Click save settings
Close the ConEmu inside window
Open ConEmu inside another window
Observe that Sync Dir is not enabled

@mfeemster
Copy link
Author

I've looked into this further, and it turns out that having the command box for sync dir empty prevents the option from saving. This seems counter intuitive since the tool tip shows what the default command is. In order for it to save and work correctly, I have to manually enter "cd \1\n" in the box.

If there is a default, it should just be used without the user having to manually enter it.

@Maximus5
Copy link
Owner

Seems like your shell is not recognized by ConEmu. You haven't posted a screenshot so I can't be sure.

@Maximus5
Copy link
Owner

Also Sync dir is not saved by design. It may harm user experience when the directory in the console is used for some operation.

@mfeemster
Copy link
Author

This seems pretty counter intuitive, the purpose of a setting is to save a specified behavior. Also, it does save, so long as the text box is not empty. I'm just saying that if a default is known, it should be auto populated and saved with that default value when the user selects the checkbox.

I have tried and verified this with both cmd.exe and powershell.exe, so I'm pretty sure ConEmu recognizes them.

Edit to clarify what happens:

Register ConEmu Inside, whether sync dir is checked or not results in a registry key being saved here:

HKEY_CLASSES_ROOT*\shell\ConEmu Inside\command

With a value of (powershell in my case):

"C:\Program Files\ConEmu\ConEmu64.exe" "/inside" /cmd powershell.exe -new_console:a

That gives no instruction to ConEmu as to how it should change directories. However, if I enter the default cd command syntax in the box:

cd \1\n

and register again, it's properly saved like so:

"C:\Program Files\ConEmu\ConEmu64.exe" "/inside=cd \1\n" /cmd powershell.exe -new_console:a

My point is that the user should not have to manually type in "cd \1\n" when selecting Sync dir, especially since ConEmu already knows what the default change directory command is since it tells you so in the tool tip. Instead, it should automatically pre-populate the text box with that command.

@Maximus5
Copy link
Owner

User have not type "cd \1\n" actually. There is a Sync column in the StatusBar. Just click it after start and ConEmu will choose "cd" command automatically.
2015-06-18_23-22-37

@mfeemster
Copy link
Author

Thanks, I did not notice the option in the status bar, as I had it hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants