feat: add modalBarrier and new color argument #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This adds a modal barrier in the background (like in dialogs for example) and the user can set the color of that barrier to make it more customizable.
- constructors always first.
- avoid lines longers than 80 lines.
- add missing trailing commas.
- use cascade.
- use final in values that doesn't change.
- omit type annotation.
- async functions are now Future<void> something async(){}.
|
Hi @gonzalogauto, Thanks so much for the PR and code cleanup. In the future, according to Instagram, we can hopefully add opacity that changes according to how zoomed the Widget is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR I have also made a refactor of the code to make it look cleaner
Future