Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bignum non-public #8155

Open
3 of 9 tasks
daverodgman opened this issue Sep 1, 2023 · 1 comment
Open
3 of 9 tasks

Make bignum non-public #8155

daverodgman opened this issue Sep 1, 2023 · 1 comment
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-crypto Crypto primitives and low-level interfaces enhancement size-m Estimated task size: medium (~1w)

Comments

@daverodgman
Copy link
Contributor

daverodgman commented Sep 1, 2023

Remove bignum.h from the public interface.

This probably requires defining a simple replacement interface for importing/exporting bignums to replace APIs that currently expose mbedtls_mpi. Structs with private fields of type mbedtls_mpi will need to reference an internal bignum header to get this type.

  • remove bignum.h from the public include folder
  • define simple public interface for importing/exporting bignums. Probably just an array of bytes with a guarantee about byte order.
  • asn1.h, asn1write.h: mbedtls_asn1_get_mpi, mbedtls_asn1_write_mpi - move to replacement interface
  • dhm.h: this will be internal
  • ecp.h: this will be internal
  • pk.h: investigate MBEDTLS_PK_DEBUG_MPI
  • rsa.h: will be internal
  • ssl.h: some private mbedtls_mpi struct fields, only for DHM in TLS 1.2 which is being removed
  • x509_crt.h:remove mbedtls_x509write_crt_set_serial() (functionality covered by mbedtls_x509write_crt_set_serial_raw)

Other consequences:

@daverodgman daverodgman added this to Mbed TLS 4.0 MUST in Backlog for Mbed TLS Sep 1, 2023
@daverodgman daverodgman added enhancement component-crypto Crypto primitives and low-level interfaces api-break This issue/PR breaks the API and must wait for a new major version size-m Estimated task size: medium (~1w) labels Oct 11, 2023
@mpg
Copy link
Contributor

mpg commented Oct 23, 2023

  • ecp.h: this should probably be internal?

Note: we can't make ecp.h internal without a regression unless we've done #7292, #7293 and #7294 first. (To clarify, since those are investigation tasks: I'm not talking about just doing the investigations, but about actually executing the tasks that will result from those investigations.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-crypto Crypto primitives and low-level interfaces enhancement size-m Estimated task size: medium (~1w)
Projects
Backlog for Mbed TLS
Mbed TLS 4.0 MUST
Development

No branches or pull requests

2 participants