-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Previewed media continues playback when preview is collapsed #644
Comments
I did some cursory investigations into this. There is a JS method There was the suggestion to just rollback this change and always refetch the content, or at least destroy videos. From my perspective:
Open to any other thoughts / suggestions. @asdfzdfj especially yours as you helped me out with the original PR, not sure if you have more thoughts now or ideas on how to handle this request. (And maybe the answer is just |
being able to "suspend" dom nodes, stash them when hiding and restore them back with the same state when unhide would be really dope and I'll do it if I could, but alas I don't know enough html/js to do that (if anyone else knows, feel free to chime in or give some pointers) the best I could think of right now is kinda hasty compromise: rollback the change, but also make the ajax embed fetch remembers the html response on successful fetch (refactor that out into a function or something), and so when it's about to fetch the embed again it could instead immediately return this stashed html to use as normal without hitting the endpoint again |
This issue is stale because it has been open 50 days with no activity. Remove stale label or comment or this will be closed in 6 days. |
Describe the bug
Described here
When an entry preview includes a video or other media playback, clicking play and collapsing the preview will not pause the media. Expectations appear to be that media playback is paused when hidden.
This functionality was changed in #296 to no longer re-download every time the preview is expanded / collapsed, which is likely what caused this to change, as before the entire preview was removed from the DOM and every expand was a new AJAX request to refetch it.
On which Mbin instance did you find the bug?
All
Which Mbin version was running on the instance?
1.5.0
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The media to pause playback
Additional context
PR that changed functionality of embedded previews
The text was updated successfully, but these errors were encountered: