fix: add ability to lose support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xsambugs
commented
Aug 8, 2022
| planForPair[__tokenA][__tokenB] = _plan; | ||
| emit AddedSupportForPairInChainlinkOracle(__tokenA, __tokenB); | ||
| emit UpdatedPlanForPair(__tokenA, __tokenB, _plan); |
There was a problem hiding this comment.
Thought this name made more sense
| @@ -29,7 +29,7 @@ contract StatefulChainlinkOracleMock is StatefulChainlinkOracle { | |||
| _addOrModifySupportForPair(_tokenA, _tokenB, _data); | |||
| } | |||
|
|
|||
| function setPricingPlan( | |||
| function determinePricingPlan( | |||
There was a problem hiding this comment.
Thought this name made more sense
0xged
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @0xged , we realized that we had a corner case where the oracle wouldn't work as expected. This scenario could happen if we removed a mapping (to USD or another token) and suddenly a pair lost support.
In that case, the pricing plan was already set, and we couldn't remove it by reconfiguring the pair (because it reverted). With this change, we can now lose support