HEVC: Trying to better support buggy SEIs (missing rbsp_stop_one_bit) #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @pwacooijmans |
|
:)
2018-06-01 12:18 GMT+02:00 Jérôme Martinez <notifications@github.com>:
… ping @pwacooijmans <https://github.com/pwacooijmans>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#865 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AdX5NNY8LUNkFvovfuvSbHRtiBFYLQtwks5t4RUKgaJpZM4UWccp>
.
|
|
Well thx for the some point at least, lets hope it doesn't take another year :) |
|
but to be honest just add a commandline message or something to log the
thing....and a log in the gui....everyone happy....all it needs to say is
OK or CORRUPT per item...everyone happy :)
2018-06-01 12:26 GMT+02:00 Pieter Cooijmans <pwacooijmans@gmail.com>:
… :)
2018-06-01 12:18 GMT+02:00 Jérôme Martinez ***@***.***>:
> ping @pwacooijmans <https://github.com/pwacooijmans>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#865 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AdX5NNY8LUNkFvovfuvSbHRtiBFYLQtwks5t4RUKgaJpZM4UWccp>
> .
>
|
|
so to give an example: nal1: ok, nal 2: ok, nal-sei: ok and some oks about
the rest of the streams EVERYONE happy and yet NO important details given
2018-06-01 12:38 GMT+02:00 Pieter Cooijmans <pwacooijmans@gmail.com>:
… but to be honest just add a commandline message or something to log the
thing....and a log in the gui....everyone happy....all it needs to say is
OK or CORRUPT per item...everyone happy :)
2018-06-01 12:26 GMT+02:00 Pieter Cooijmans ***@***.***>:
> :)
>
> 2018-06-01 12:18 GMT+02:00 Jérôme Martinez ***@***.***>:
>
>> ping @pwacooijmans <https://github.com/pwacooijmans>
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#865 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AdX5NNY8LUNkFvovfuvSbHRtiBFYLQtwks5t4RUKgaJpZM4UWccp>
>> .
>>
>
>
|
|
don't make it too complicated...the avg consumer using mediainfo has no
clue whatsoever
2018-06-01 12:43 GMT+02:00 Pieter Cooijmans <pwacooijmans@gmail.com>:
… so to give an example: nal1: ok, nal 2: ok, nal-sei: ok and some oks about
the rest of the streams EVERYONE happy and yet NO important details given
2018-06-01 12:38 GMT+02:00 Pieter Cooijmans ***@***.***>:
> but to be honest just add a commandline message or something to log the
> thing....and a log in the gui....everyone happy....all it needs to say is
> OK or CORRUPT per item...everyone happy :)
>
>
> 2018-06-01 12:26 GMT+02:00 Pieter Cooijmans ***@***.***>:
>
>> :)
>>
>> 2018-06-01 12:18 GMT+02:00 Jérôme Martinez ***@***.***>:
>>
>>> ping @pwacooijmans <https://github.com/pwacooijmans>
>>>
>>> —
>>> You are receiving this because you were mentioned.
>>> Reply to this email directly, view it on GitHub
>>> <#865 (comment)>,
>>> or mute the thread
>>> <https://github.com/notifications/unsubscribe-auth/AdX5NNY8LUNkFvovfuvSbHRtiBFYLQtwks5t4RUKgaJpZM4UWccp>
>>> .
>>>
>>
>>
>
|
|
They are just happy if they get all the checks in the checklist :)
2018-06-01 12:48 GMT+02:00 Pieter Cooijmans <pwacooijmans@gmail.com>:
… don't make it too complicated...the avg consumer using mediainfo has no
clue whatsoever
2018-06-01 12:43 GMT+02:00 Pieter Cooijmans ***@***.***>:
> so to give an example: nal1: ok, nal 2: ok, nal-sei: ok and some oks
> about the rest of the streams EVERYONE happy and yet NO important details
> given
>
> 2018-06-01 12:38 GMT+02:00 Pieter Cooijmans ***@***.***>:
>
>> but to be honest just add a commandline message or something to log the
>> thing....and a log in the gui....everyone happy....all it needs to say is
>> OK or CORRUPT per item...everyone happy :)
>>
>>
>> 2018-06-01 12:26 GMT+02:00 Pieter Cooijmans ***@***.***>:
>>
>>> :)
>>>
>>> 2018-06-01 12:18 GMT+02:00 Jérôme Martinez ***@***.***>:
>>>
>>>> ping @pwacooijmans <https://github.com/pwacooijmans>
>>>>
>>>> —
>>>> You are receiving this because you were mentioned.
>>>> Reply to this email directly, view it on GitHub
>>>> <#865 (comment)>,
>>>> or mute the thread
>>>> <https://github.com/notifications/unsubscribe-auth/AdX5NNY8LUNkFvovfuvSbHRtiBFYLQtwks5t4RUKgaJpZM4UWccp>
>>>> .
>>>>
>>>
>>>
>>
>
|
|
you went well out of your time zone there to fix this, thanks a LOT for such dedicated commitment to making the world a better place for all of us :) |
|
thx a LOT :) |
|
Well thx to you I can say now with 100% certainty that it's a total loss of
files due to this bug :(...however on the bright side it's better than
figuring this out after 10 years :)
2018-06-01 17:59 GMT+02:00 Jérôme Martinez <notifications@github.com>:
… Windows snapshot having this update
<https://mediaarea.net/download/snapshots/binary/mediainfo-gui/20180601-4/MediaInfo_GUI_18.05.20180601_Windows.exe>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#865 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AdX5NOPna0Mx8Pe1DzbNeMpcCnMG8HdVks5t4WT2gaJpZM4UWccp>
.
|
|
I mean it's not like I don't want to retire someday :)
2018-06-01 20:07 GMT+02:00 Pieter Cooijmans <pwacooijmans@gmail.com>:
… Well thx to you I can say now with 100% certainty that it's a total loss
of files due to this bug :(...however on the bright side it's better than
figuring this out after 10 years :)
2018-06-01 17:59 GMT+02:00 Jérôme Martinez ***@***.***>:
> Windows snapshot having this update
> <https://mediaarea.net/download/snapshots/binary/mediainfo-gui/20180601-4/MediaInfo_GUI_18.05.20180601_Windows.exe>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#865 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AdX5NOPna0Mx8Pe1DzbNeMpcCnMG8HdVks5t4WT2gaJpZM4UWccp>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point we should add messages when there is an error in the bitstream, but for the moment I didn't figure the best approach (with generic code for handling errors as much as possible, and not poluting the default output)
From vote https://mediaarea.net/Vote/Support-Buggy-Hevc-H-265-Sei-171
Issue from encoder, see rigaya/NVEnc#51 (comment)