Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpacking a non-rawcooked FFV1/MKV #118

Open
pjotrek-b opened this issue Jul 5, 2018 · 8 comments
Open

Unpacking a non-rawcooked FFV1/MKV #118

pjotrek-b opened this issue Jul 5, 2018 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@pjotrek-b
Copy link

When starting rawcooked with a "normal" FFV1/MKV file (=not produced by rawcooked), rawcooked processes the whole file (CPU at 100%) - but only at the very end says:

Untested More video frames in source content than saved frame headers in reversibility data, please contact info@mediaarea.net if you want support of such file

Would it be possible to tell the user earlier that nothing will be output?

Or even more daring:
Would it be possible to actually output a generated DPX sequence for such files?
(But that's wishlist of course 😉 )

@JeromeMartinez
Copy link
Member

Would it be possible to tell the user earlier that nothing will be output?

Oops... True, I should test sooner that there are issues here.

Would it be possible to actually output a generated DPX sequence for such files?

More work (I need to create the DPX header for every flavor of FFV1) but doable, just wondering how useful it is vs e.g. FFmpeg directly (if/when my decoder is quicker, it is another story... ;-) )

@JeromeMartinez JeromeMartinez added the bug Something isn't working label Jul 5, 2018
@JeromeMartinez JeromeMartinez self-assigned this Jul 5, 2018
@pjotrek-b
Copy link
Author

Sorry that this report contains 2 different things:

  1. Report earlier that this is not a rawcooked file
  2. Deal with non-rawcooked files.

Shall I create a separate issue for no.2 - as a wishlist thing?
I think it'd be useful (but absolutely no priority right now), because using rawcooked instead of FFmpeg would be super-easy, all-in-one step with close-to-no-error potential 😁

e.g. printf syntax for filenames might be scary for some: %03d.dpx? %06d.dpx? You know... 😨
Just thinking out loud...

@JeromeMartinez
Copy link
Member

Shall I create a separate issue for no.2 - as a wishlist thing?

Would be better, true, I will not implement that at the same time.

e.g. printf syntax for filenames might be scary for some: %03d.dpx? %06d.dpx? You know...

Issue is that I'll have to decide arbitrary of the format. but true, easier for beginners.

Just thinking out loud...

And will not be the priority until a sponsor shows interest.
(does not prevent to open a ticket, so we can provide ideas to sponsors).

@retokromer
Copy link
Collaborator

Would it be possible to tell the user earlier that nothing will be output?

True, I should test sooner that there are issues here.

Is this implemented in the current head?

@JeromeMartinez
Copy link
Member

Not yet implemented.
For this one I think it could worth it only if someone is interested in sponsoring it (not a big issue for implementing it but more work not in the initial scope of the project IMO).

@retokromer
Copy link
Collaborator

If I use normal Matroska/FFV1 file, i.e. not a RAWcooked one, then I receive the error message:

Time=00:00:00 (0%)    Segmentation fault: 11

I suggest to have a more telling message.

@JeromeMartinez
Copy link
Member

Segmentation fault:

Crash is not a feature :).
Will do.

@retokromer
Copy link
Collaborator

retokromer commented Mar 29, 2019

Crash is not a feature :).

Especially not in the airlines industry…

Will do.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants