Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Revert using Babel. #165

Merged
merged 4 commits into from Aug 13, 2019
Merged

Revert using Babel. #165

merged 4 commits into from Aug 13, 2019

Conversation

ksaaskil
Copy link
Contributor

@ksaaskil ksaaskil commented Aug 13, 2019

  • Change @types/node to @types/node@8 so we aren't accidentally assuming Node 12 when compiling TypeScript
  • Delete Babel
  • Revert back to compiling both types and JS with tsc
  • Using Babel with the runtime plugin for polyfills is great but currently it does not support specifying the Node.js version so everything gets polyfilled (Use babel runtime plugin to polyfill instead of requiring core-js. #164), therefore skip using Babel for now and maybe set @types/node@6 in a future PR

@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #165 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #165   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          42       42           
  Lines        1426     1426           
  Branches      328      328           
=======================================
  Hits         1273     1273           
  Misses        153      153
Impacted Files Coverage Δ
packages/unmock-node/src/serialize/index.ts 90% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9353c2...fff94cb. Read the comment docs.

@ksaaskil ksaaskil merged commit 4a5f355 into dev Aug 13, 2019
@ksaaskil ksaaskil deleted the es-2015 branch August 13, 2019 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants