Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Protocols for contribution? #5

Closed
Benjamin-Piper opened this issue Feb 25, 2021 · 2 comments
Closed

Question: Protocols for contribution? #5

Benjamin-Piper opened this issue Feb 25, 2021 · 2 comments

Comments

@Benjamin-Piper
Copy link
Contributor

Hi,

I'm new to making contributions to other repos, but I have a couple functions that I think would fit nicely here.

Do you have any protocols for pull requests and suggestions?

@MeetMartin
Copy link
Owner

Hi Benjamin,

If you feel confident about your code you can simply use a standard process for pull requests https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests. I will get a notification and review your code or start a discussion under it.

If you want to start with suggestions and discuss what you feel is missing first, just use the github issues as you have done now.

For me, it's important to maintain certain purity from a functional code perspective.

Otherwise, the documentation for the website gets generated automatically from the code documentation. This is why the in-code documentation tends to be quite large.

I am happy to work together to make this all click :)

@Benjamin-Piper
Copy link
Contributor Author

Thanks, I'll open up a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants