New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some possible refactors #4

Open

duchuyctlk wants to merge 2 commits into Meetic:master from duchuyctlk:dev

duchuyctlk commented Jun 1, 2016

Hi,
I by chance see your project and find some possible LOCs those could be refactors.
Could you please take a look at this?

Refactors those are applied in this PR:

Module MaryPopup: use ternary in simple cases, split values into constants, declare local variables to reduce frequent method calls
Module app: Make PopupActivity be extended by the others

Cheers,

HuyDuc added 2 commits

June 1, 2016 14:28


          Refactor: use ternary in simple cases, split values into constants, d…

e7b33bb

…eclare

local variables to reduce frequent method calls


          Refactor: Make PopupActivity be extended by the others

7a0c2ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment