Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This repository is in violation of YOLOv5 GPL 3.0 License #765

Closed
glenn-jocher opened this issue Sep 30, 2021 · 6 comments · Fixed by #781
Closed

This repository is in violation of YOLOv5 GPL 3.0 License #765

glenn-jocher opened this issue Sep 30, 2021 · 6 comments · Fixed by #781
Labels
High Priority This issue will be handled in high priority

Comments

@glenn-jocher
Copy link

glenn-jocher commented Sep 30, 2021

This repository is using original code from https://github.com/ultralytics/yolov5 which is licensed under GPL 3.0. Use of YOLOv5 code is permitted under GPL 3.0 for any purpose including commercial as long as the derivative work is licensed under the same GPL 3.0 license and sources are disclosed. Examples of YOLOv5 functions in this repository:

def augment_hsv(img, hgain=0.015, sgain=0.7, vgain=0.4):

def box_candidates(box1, box2, wh_thr=2, ar_thr=20, area_thr=0.2):

def random_perspective(

And their YOLOv5 sources originally published May 2020 under GPL 3.0:

https://github.com/ultralytics/yolov5/blob/89a6e9ffa78a43c17c5405caa144e514b4afd0ef/utils/augmentations.py#L48-L49

https://github.com/ultralytics/yolov5/blob/89a6e9ffa78a43c17c5405caa144e514b4afd0ef/utils/augmentations.py#L273-L274

https://github.com/ultralytics/yolov5/blob/89a6e9ffa78a43c17c5405caa144e514b4afd0ef/utils/augmentations.py#L125-L126

I would ask that you come into compliance by immediately updating your license to GPL 3.0 and citing the sources for these functions or removing all YOLOv5 code. Thank you!

EDIT: I can confirm these functions are all original to YOLOv5 because I wrote them myself from scratch, and I am the YOLOv5 author.

https://github.com/ultralytics/yolov5/blob/master/LICENSE
Screen Shot 2021-09-30 at 5 15 44 PM

@Joker316701882
Copy link
Member

@glenn-jocher Hi, thank you for pointing this out. We are sorry for our negligence and are aware of the violation. We will soon remove the relevant code and inform you the corresponding updates.

@FateScript FateScript added the High Priority This issue will be handled in high priority label Oct 3, 2021
@Ar-Ray-code
Copy link
Contributor

@FateScript @Joker316701882

Will you fix about v0.1.0 ?

YOLOX-ROS is using YOLOX-v0.1.0, and I'll update this LICENSE according to your trends. Thank you.

@FateScript
Copy link
Member

@FateScript @Joker316701882

Will you fix about v0.1.0 ?

YOLOX-ROS is using YOLOX-v0.1.0, and I'll update this LICENSE according to your trends. Thank you.

After fixing this, we will release version 0.2.0. WDYT?

@FateScript
Copy link
Member

Hello @glenn-jocher , following the request of GPL 3.0 License, #781 fixes all the violation. It LGTM. WDYT?

@FateScript
Copy link
Member

gently ping @glenn-jocher

@FateScript
Copy link
Member

Long time no reply, I will close this issue. Feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority This issue will be handled in high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants