Datehumanizertests and implementation #1
Conversation
| @@ -8,7 +8,7 @@ | |||
| <option name="gradleHome" value="$USER_HOME$/tools/gradle" /> | |||
| <option name="modules"> | |||
| <set> | |||
| <option value="$PROJECT_DIR$" /> | |||
| <option value="E:\Users\christiaan\IdeaProjects\Lessthandot\Humanizer.jvm" /> | |||
|
Yes. Not sure how those changes got int here. Also, I'm going to refactor the tests a bit to extract some function and make it less code. But awesome stuff from @chrissie1 |
| @@ -1,11 +0,0 @@ | |||
| <component name="libraryTable"> | |||
There was a problem hiding this comment.
Hmmm, do we not need this? I have no idea :p
P.S. This is the most clueless code review I've ever done!!
|
Thanks for the great contribution @chrissie1. I honestly have no idea about Kotlin or the JVM. I left some comments on things I thought might require change! Let me know what you think. |
|
WRT localisation, Humanizer didn't have ANY for a year and only recently we started adding them and the required support in. So no worries for now. |
|
Could you also please add your cool new addition to readme file so new arrivals know what's there? We have a release-notes file with PR entries in Humanizer. How do you guys feel about creating a release-notes file and adding PRs in? |
|
Ok, I will add to the readme. I cloned and then opened the project in intellij. I'm sure it asked me a question to which I said yes. I moved the project since then so the path it has there isn't even correct. |
|
And I would welcome the refactor. It works but probaly not the best kotlin code out there. red, green, refactor. I'm at the green stage ;-). |
…ot have found a slight bug.
|
now tests for 59 minutes. |
|
I'm not sure what happened with project files so for now I've just copied your work and will push it. Can you re-import? |
Same tests as in the .net version apart from one extra one. Might be a slightly different implementation no localization yet, all just English.
Not sure why intellij changed the idea files so you should probably not merge those. But what do I know.
Happy building.