Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken backwards compatibility #37

Closed
martinkrcho opened this issue Apr 6, 2021 · 2 comments · Fixed by #38
Closed

Broken backwards compatibility #37

martinkrcho opened this issue Apr 6, 2021 · 2 comments · Fixed by #38
Assignees

Comments

@martinkrcho
Copy link
Contributor

We have a bug in the extension core:
https://github.com/WPWhiteSecurity/wsal-extension-template/blob/master/core/class-extension-core.php#L57-L63

This prevents the most recent versions of extensions to load correctly if any of the older extensions is installed. We need to rename variable $core_settings to $extention_main_file_path.

While we're at it, please rename $extention_main_file_path to $extension_main_file_path both in constructor and the class property (notice 1 changed letter to fix spelling). Also $extention_plugin_name needs changing to $extension_plugin_name.

@sdobreff
Copy link
Contributor

sdobreff commented Apr 6, 2021

/cib

@create-issue-branch
Copy link

Branch issue-37-Broken_backwards_compatibility created!

@sdobreff sdobreff linked a pull request Apr 6, 2021 that will close this issue
Version 1.1.0 automation moved this from In progress to Done Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Version 1.1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants