-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow/Display error #88
Comments
By the way: Why is the title link in color blue? Until a few days ago I have used this fork https://github.com/clarinetJWD/lovelace-yet-another-expander-card and there is the link colored in primary color |
I'm also experiencing this issue. If it helps I am using the card in the Sections view type rather than the default Masonry but I see the issue occur on both types. |
Thanks for reporting. I didn’t changed the font size or the color so this should be reproducible also on the original one. For your issue interesting I had the other way around with display blocks it didn’t work. I have to check if it really a issue with long friendly names Could your share your yaml code. Makes it easier to reproduce for me. |
You can reproduce by creating any card that renders a very long name for the entity. For instance: type: custom:expander-card
gap: 0.6em
padding: 1em
clear: false
title: Expander
overlay-margin: 2em
child-padding: 0.5em
button-background: transparent
cards:
- type: entities
entities:
- entity: sun.sun
name: This is an entity with a very long name that breaks things The same I'm not using any custom themes or css EDIT: Removing the default CSS values almost fixes things. Removing |
Ok I will try it. I have good experience to start with 0 default values and then increase it, if needed. The second issue with color. I saw I fixed it with card mod, because my PR was not merged in the original repo. I have to check my old PR and have to move it. Third issue with font size, I have to look into deeper |
Overwriting the defaults or adding a note in the documentation about sane defaults sounds like a good idea. Though I think the overflow fix is more than just setting 0 over defaults since it doesn't quite fix things and the actual fix should have the element respecting outside container width. But these are all small issues that can wait till you get back from vacation! Enjoy. |
Yes the width issue I have to look into. You can look into the last PR there I added a css style for the layouting. |
@MelleD I've just switched from the original card to yours, and I can confirm that the overflow bug with long names was already there in the original card. |
Hey @hvorragend
Where did you try it? EDIT: I guess the issue is the second label, when this is too long (see #100). Additional problem is if you use padding. AND on ios app it looks completely different and nothing is working :( See here with a smaller label it works: I think i can fix the case when the second label is not too long with "block grid". @FoxxMD maybe you can test your cases, if this fix will work for you. Question: |
Fixed in 1.2.2 |
@MelleD that fixed it! Thanks for the continued work on this amazing card ❤️ |
Checklist:
Release with the issue:
Last working release (if known):
Unknown
Browser and Operating System:
Safari/iOS
Description of problem:
There seem to be problems if the text in an entity card becomes too long.
Firstly, the HA-Card and the childrencard grow with it. With
"display: block;"
instead of"display: grid;"
it seems to work.Secondly, the font size is too large on a smartphone. But only if the friendly names are too long. Tested in Safari under iOS.
Additional information:
no console errors
The text was updated successfully, but these errors were encountered: