fix: Error with JSONB columns containing arrays. #279
Conversation
|
@sebastianswms @visch I'm curious what you think of the more general solution in #239? |
|
@edgarrmondragon #239 seems better I dislike how counter-intuitive it is from a user's perspective as If I"m pulling a JSONB column I'd assume it's going to serialize as an object in jsonschema. So we should probably add a decent readme with the examples. @edgarrmondragon has examples in that issue would help folks understand the why here (JSONB can have a bunch of values) What do you think @sebastianswms curious if you have a different opinion. If not we should just get edgars PR in. It looks like I tested it and just needed to upgrade my dependencies (I was testing the different scenario's myself) |
|
This goes deeper than I thought. After reading through #239 it seems like a fully variant schema is the better solution. |
|
Can you get that Readme info added to tap-postgres for JSONB? I'll get #239 merged. Should probably be a sepearte pr We should close this one based on #279 (comment) right @sebastianswms ? |
|
Closed because #239 is better. |
Postgres JSONB columns would always be reported as jsonschema objects, even though they can sometimes hold jsonschema arrays. This can cause downstream issues, such as those documented in the below target-postgres issue.
Closes MeltanoLabs/target-postgres#189