Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google assistant dont give me images from search #119

Open
Tintasmen opened this issue Feb 13, 2021 · 7 comments
Open

Google assistant dont give me images from search #119

Tintasmen opened this issue Feb 13, 2021 · 7 comments

Comments

@Tintasmen
Copy link

Tintasmen commented Feb 13, 2021

2

Describe the bug
Google assistant dont give me imagens from search

To Reproduce
Steps to reproduce the behavior:

  1. Images of Horses
  2. Result:
    imagens

Desktop (please complete the following information):

  • OS: [e.g. Windows 7 Ultimate]
  • Version [e.g. 1.0.0-rc.1]

Awesome work! Continue

@93boba
Copy link

93boba commented Feb 13, 2021

I can confirm this issue. I am facing the same problem on:

Edition Windows 10 Pro
Version 20H2
Installed on ‎29-‎Dec-‎20
OS build 19042.804
Experience Windows Feature Experience Pack 120.2212.551.0

The only time I get the visuals is when I ask for the weather.

This is super awesome work! Let me know if you need any more details.

@Juka117
Copy link

Juka117 commented Feb 14, 2021

This is happening due to a race condition. The phrase "here are some pictures I found" is tricking the logic into thinking it's a text based result instead of google images array. I was able to switch to the proper if condition by setting the innerText to "https://www.google.com/search?tbm=isch" manually (line 2428 of main.js). Sequence of events has to be changed to waiting for results type before speaking the confirmation action and base the condition on the type of result.
Capture2

@Tintasmen
Copy link
Author

So how i can fix this problem? Would be awesome have images on search google assistant

@Juka117
Copy link

Juka117 commented Feb 14, 2021

I haven't gotten to that part yet unfortunately mainly because I'm very new to Google Assistant and how it works. If I had to reason it out, it should be somewhere close to triggering the proper flag status/type using the keyword that means images; not sure if this has to be coded at this level or if it's already evaluated at the API level though. Pretty sure someone with more knowledge will beat me to it in no time!

@Tintasmen
Copy link
Author

No problem someday you will fix it ! :)

@Prayag2
Copy link

Prayag2 commented Feb 23, 2021

Same issue here. I use Manjaro KDE (Linux).

@Manasx100
Copy link

Same issue Ubuntu 21.04 development branch seems like something with api maybe some api may fix it and modification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants