Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEM-121] Swipe action for saving posts #231

Closed
leftbones opened this issue Jun 29, 2023 · 10 comments · Fixed by #805
Closed

[MEM-121] Swipe action for saving posts #231

leftbones opened this issue Jun 29, 2023 · 10 comments · Fixed by #805
Assignees
Labels
enhancement request for enhancement to current app or features high priority should be implemented or fixed soon

Comments

@leftbones
Copy link

leftbones commented Jun 29, 2023

I know customization for swipe gestures are off the table for now, but I think a swipe gesture for saving is crucial. I’ve been trying many other Lemmy apps, and they almost all have this feature.

Ideally, swiping a post left should first bring up the reply option, then swiping further should bring up the save option. Right now, it just does reply and then nothing else. That empty space could be utilized!

MEM-121

@leftbones leftbones added enhancement request for enhancement to current app or features linear labels Jun 29, 2023
@gkasdorf
Copy link
Collaborator

If you noticed, there is a second "slot" now for the right->left swipe that is empty. Was thinking of adding it there.

@leftbones
Copy link
Author

If you noticed, there is a second "slot" now for the right->left swipe that is empty. Was thinking of adding it there.

Exactly what I meant! That’s where it is on Apollo and most of the other Lemmy apps, it definitely would help with my muscle memory too haha.

@gkasdorf
Copy link
Collaborator

gkasdorf commented Jun 29, 2023

In your opinion, should it be the first option or the second? I'm fine with either.

I've noticed that we might need to increase the distance for the right-left actions. It seems that's its a bit too easy to miss the first action right now and hit the second one, maybe because I believe Apollo defaulted to reply being the second option rather than the first.

Eventually we will have customization for that, but in the meantime I need some default to go with.

@leftbones
Copy link
Author

Personally I think the second option is best for saving. It’s easier to do quickly, whereas stopping at the reply option has to be more deliberate.

@gkasdorf
Copy link
Collaborator

Yea I think I agree.

Here's another question:

Should saved posts be stored locally (as well as being updated on Lemmy) and available to all of your accounts? I.e. if you save something on x@lemmy.ml it will be available in your saved list so you can go to it on y@lemmy.world

@leftbones
Copy link
Author

Hm that I’m not sure about since I don’t use multiple accounts, maybe someone else could chime in on that.

I would think that accounts would have separate saves though.

@gkasdorf gkasdorf added linear and removed linear labels Jun 30, 2023
@gkasdorf gkasdorf changed the title Swipe action for saving posts [MEM-121] Swipe action for saving posts Jun 30, 2023
@gkasdorf gkasdorf added linear and removed linear labels Jun 30, 2023
@gkasdorf gkasdorf removed their assignment Jun 30, 2023
@gkasdorf gkasdorf added linear and removed linear labels Jun 30, 2023
@InquisicionEspanola
Copy link
Contributor

Separate saves would be preferred imho.

@gkasdorf
Copy link
Collaborator

gkasdorf commented Jul 7, 2023

I'll address this issue today.

@leftbones
Copy link
Author

I'll address this issue today.

When I saw the giant update today I was hoping this change made it in, but no luck. Hopefully next time!

@sgriff96 sgriff96 removed the linear label Jul 8, 2023
@eoddc5 eoddc5 added the high priority should be implemented or fixed soon label Jul 11, 2023
@sgriff96 sgriff96 self-assigned this Jul 22, 2023
@gkasdorf
Copy link
Collaborator

@leftbones I think Sean is either working on this now or is finished with it 😉

@sgriff96 sgriff96 linked a pull request Jul 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement request for enhancement to current app or features high priority should be implemented or fixed soon
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants