Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Share button not automatically download image #491

Closed
martinjose opened this issue Jul 8, 2023 · 6 comments
Closed

Make Share button not automatically download image #491

martinjose opened this issue Jul 8, 2023 · 6 comments
Labels
bug Something isn't working or working properly critical priority requires attention on hold items that are currently known but not being worked on question Further information is requested

Comments

@martinjose
Copy link

Describe the bug
When clicking the "Share" button while viewing an image, it immediately displays the "Downloading image..." modal and never completes. It is then impossible to continue using the app without force closing.

To Reproduce
Steps to reproduce the behavior:

  1. Launch Memmy
  2. Open any image from a post.
  3. Select the "Share" button.
  4. The "Downloading Image..." modal appears permanently.

Expected behavior
The system's Share API dialog should appear upon selecting the "Share" button.

Screenshots
image

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro Max
  • OS: iOS 16.5.1 20F75
  • Version 0.1.0 (11)

Logs:
Logs were emailed.
@martinjose martinjose changed the title Share Button Automatically Initiates Image Download [BUG] Share Button Automatically Initiates Image Download Jul 8, 2023
@sgriff96
Copy link
Collaborator

sgriff96 commented Jul 8, 2023 •
edited
Loading

I think this is a bit of a technical limitation at the moment? @gkasdorf would know more though. This is intentional behavior though at the moment.

@sgriff96 sgriff96 added the enhancement request for enhancement to current app or features label Jul 8, 2023
@sgriff96 sgriff96 changed the title [BUG] Share Button Automatically Initiates Image Download Make Share button not automatically download image Jul 8, 2023
@sgriff96 sgriff96 added the question Further information is requested label Jul 8, 2023
@martinjose
Copy link
Author

@sgriff96 I did some further testing and found that the issue I am referring to only occurs when clicking on an image thumbnail from the post list while in compact view. At that point the application gets stuck on "Downloading Image..." and becomes unresponsive. Memmy never transitions to the actual share dialog. I have to force close the app to resume using it.

@eoddc5 eoddc5 added bug Something isn't working or working properly and removed enhancement request for enhancement to current app or features labels Jul 11, 2023
@eoddc5
Copy link
Contributor

eoddc5 commented Jul 11, 2023

I cannot replicate this. My phone completes the share request from compact (and regular) modes. @martinjose are you still seeing this issue?

@eoddc5 eoddc5 added on hold items that are currently known but not being worked on critical priority requires attention labels Jul 11, 2023
@eoddc5
Copy link
Contributor

eoddc5 commented Jul 11, 2023

Setting as critical priority in the case that this is able to be replicated by others

This is ann app crash behavior if it’s actually verified to be a bug and should be fixed asap

“On hold” until validated with reporter and others @sgriff96 @gkasdorf can you two try to replicate?

@gkasdorf
Copy link
Collaborator

This is actually resolved in the latest version I believe. There was an issue in compact view where the image would not download, however this should be fixed. @martinjose can you download the latest version and see if this still happens?

@martinjose
Copy link
Author

@gkasdorf You are correct. Yesterday's update did resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working or working properly critical priority requires attention on hold items that are currently known but not being worked on question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eoddc5 @martinjose @sgriff96 @gkasdorf