Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighting becomes "blocky" under certain conditions #19

Open
Braboware opened this issue Sep 28, 2023 · 1 comment
Open

Lighting becomes "blocky" under certain conditions #19

Braboware opened this issue Sep 28, 2023 · 1 comment
Labels
bug Something isn't working engine bug A bug that is a result of the engine, that we can't do much about on a project level help wanted Extra attention is needed wontfix This will not be worked on

Comments

@Braboware
Copy link

Not entirely sure what causes it but often when the camera gets close to a light source a blocky outline of the light can be seen. It should have something to do with the affine mapping POSITION /= abs(POSITION.w); line because I removed the rest of the shader and the blocky effect remains until I comment it out.

Interestingly you can also get the effect with the default godot shader if you crank the light's attenuation to some crazy values so maybe that'll give some clues as to what's going on

I have an example project that shows both
godot-psx blocky lighting.zip

@MenacingMecha
Copy link
Owner

Hmm. I mean if it also happens with the default shader with extreme settings, I think we can safely classify this as an engine bug.

I'm not sure what's causing this, or what/if can be done on my end - so for now I think this just needs to be left open. I will say these shaders aren't designed with playing nicely with real time lighting in mind, so some level of jank is always to be expected.

Thank you for the detailed reproduction scene, also.

@MenacingMecha MenacingMecha added bug Something isn't working help wanted Extra attention is needed wontfix This will not be worked on engine bug A bug that is a result of the engine, that we can't do much about on a project level labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working engine bug A bug that is a result of the engine, that we can't do much about on a project level help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants