Use UIPageViewController to allow swiping between Top/Recent Stories #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the View Hierachy
- Removes all Login Segue - Allows multiple login state observer instead of a one-to-one delegate
|
Wow, this is great. Solid job @jamztang |
|
Thanks! |
|
I will fix the merge issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #92. This requirement introduced a situation that more than one StoryTableViewController will be on screen at the same time. Using delegate pattern in LoginViewControllerDelegate is not able to tell every VC instance to do proper operation when user login/logouts.
Therefore this has to include a refactor on how to deal with Login status changes, which will encapsulate in three classes, all inside
LoginService.swift.LoginStateHandler is an observer and automatically fires when user login or logout.
LoginAction is a reusable class that automatically configures and presents our LoginViewController so we can remove all the duplicated segues which was everywhere in Storyboard
LogoutAction is also a reusable class to perform correct clean up operation.