Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

Bug with pause method #27

Closed
3eif opened this issue May 17, 2020 · 5 comments · Fixed by #30
Closed

Bug with pause method #27

3eif opened this issue May 17, 2020 · 5 comments · Fixed by #30
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@3eif
Copy link
Contributor

3eif commented May 17, 2020

If you add a song to the queue, then pause the queue using the pause method, then add another song to the queue, erela.js will skip all songs in the queue and emit the trackStart event for each song in the queue. This might cause the bot to spam depending on how many songs are in the queue.

image

@anishshobithps anishshobithps added bug Something isn't working help wanted Extra attention is needed labels May 17, 2020
@anishshobithps anishshobithps added this to the v2 milestone May 17, 2020
@anishshobithps anishshobithps linked a pull request May 25, 2020 that will close this issue
@Solaris9
Copy link
Contributor

This seems to be fixed with the rewrite version with slight alteration where you play tracks.

if (!player.playing && !player.paused && player.queue.length === 1) player.play()

If this seems to persist with rewrite then reopen this issue.

@HoaX7
Copy link

HoaX7 commented Dec 13, 2020

Hi, Im facing the same bug but not when you add songs to a queue, when you stop the player and then add songs again

@Solaris9
Copy link
Contributor

Solaris9 commented Dec 13, 2020

Please create a new issue about what you're experiencing.

@HoaX7
Copy link

HoaX7 commented Dec 13, 2020

sure but the solution commented on here didn't work

@Solaris9
Copy link
Contributor

Because this is a old bug that is fixed about pausing, you said yours was stopping the player.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants