Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move development to a separated branch. #18

Open
vldmrkl opened this issue Nov 10, 2018 · 1 comment
Open

Move development to a separated branch. #18

vldmrkl opened this issue Nov 10, 2018 · 1 comment
Assignees
Labels
community 🌎 This issue affects our community at large discussion 🧠 This issue should be discussed before a patch is submitted enhancement 🌈 New feature or request nice to have 👜 This is a nice feature, but not mandatory

Comments

@vldmrkl
Copy link
Collaborator

vldmrkl commented Nov 10, 2018

After we set up the project (Initialized create-react-app, added Travis CI, Readme.md, Contributing.md, I think we should move the main part of development from 'master' branch to develop branch.

So the idea is that we are going to push smaller changes into develop, and master is the branch where the source code of HEAD always reflects a production-ready state (read https://nvie.com/posts/a-successful-git-branching-model/ for inspiration).

It should increase maintainability of the project.

@vldmrkl vldmrkl added enhancement 🌈 New feature or request discussion 🧠 This issue should be discussed before a patch is submitted nice to have 👜 This is a nice feature, but not mandatory labels Nov 10, 2018
@vldmrkl vldmrkl changed the title Move development to separated branch. Move development to a separated branch. Nov 10, 2018
@seanprashad
Copy link
Contributor

Sorry for not getting around to this sooner @klymenkoo - I haven't discussed this as yet with Mera, but here are my brief thoughts until she can join us:

  • I've seen this method of branching before and it has worked out quite well! I am open to the idea of having something like master (which will eventually be deployed to Heroku) and develop (where PR's will be opened against, also available on a dev version of Heroku for us to play around with)

  • With that being said, I don't have a problem with maintaining the current flow of work from contributorsName/issue-X into master - I'm a big believer in "If it's not broken, don't fix it" but let's hear what others have to say

Are there any other OSS projects that use this method of branching? I'd be interested in talking to those maintainers to get a better understanding if this is something we want to pursue!

@seanprashad seanprashad added the community 🌎 This issue affects our community at large label Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community 🌎 This issue affects our community at large discussion 🧠 This issue should be discussed before a patch is submitted enhancement 🌈 New feature or request nice to have 👜 This is a nice feature, but not mandatory
Projects
None yet
Development

No branches or pull requests

3 participants