Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address NA counts in prepare_ae_specific() #166

Merged
merged 3 commits into from Aug 15, 2023
Merged

Address NA counts in prepare_ae_specific() #166

merged 3 commits into from Aug 15, 2023

Conversation

LittleBeannie
Copy link
Collaborator

No description provided.

@LittleBeannie LittleBeannie linked an issue Jul 26, 2023 that may be closed by this pull request
Display item if AE term has NA in AE specific #101
Closed
@LittleBeannie LittleBeannie self-assigned this Jul 26, 2023
@LittleBeannie LittleBeannie mentioned this pull request Jul 26, 2023
Closed
@LittleBeannie
Copy link
Collaborator Author

It looks the CMD check fails because of an unused argument.
image
But this argument is already available in the latest version of metalite, see https://github.com/Merck/metalite/blob/main/R/collect_n_subject.R#L46...

Does anyone have met similar problem before?

@nanxstats nanxstats changed the title address NA counts in prepare_ae_specific Address NA counts in prepare_ae_specific() Jul 26, 2023
@nanxstats
Copy link
Collaborator

It looks the CMD check fails because of an unused argument. But this argument is already available in the latest version of metalite, see https://github.com/Merck/metalite/blob/main/R/collect_n_subject.R#L46...

Does anyone have met similar problem before?

Without special configuration, the GitHub Actions workflows use the CRAN version of all dependencies to check the package. So metalite needs to be updated on CRAN to make this pass.

@LittleBeannie
Copy link
Collaborator Author

It looks the CMD check fails because of an unused argument. But this argument is already available in the latest version of metalite, see https://github.com/Merck/metalite/blob/main/R/collect_n_subject.R#L46...
Does anyone have met similar problem before?

Without special configuration, the GitHub Actions workflows use the CRAN version of all dependencies to check the package. So metalite needs to be updated on CRAN to make this pass.

Thanks for the explanation!

@nanxstats nanxstats merged commit 147f9d3 into main Aug 15, 2023
8 checks passed
@nanxstats nanxstats deleted the 101-display-item-if-ae-term-has-na-in-ae-specific branch August 15, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangben718 wangben718 wangben718 approved these changes

@nanxstats nanxstats Awaiting requested review from nanxstats

@elong0527 elong0527 Awaiting requested review from elong0527

Assignees

@LittleBeannie LittleBeannie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display item if AE term has NA in AE specific
3 participants
@LittleBeannie @nanxstats @wangben718