Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: remove specific libreoffice version #68

Merged
merged 1 commit into from Dec 4, 2021
Merged

Conversation

elong0527
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #68 (b7e1f27) into master (53e795e) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   93.30%   93.09%   -0.21%     
==========================================
  Files          36       36              
  Lines        1836     1840       +4     
==========================================
  Hits         1713     1713              
- Misses        123      127       +4     
Impacted Files Coverage Δ
R/rtf_convert_format.R 14.28% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e795e...b7e1f27. Read the comment docs.

@nanxstats
Copy link
Collaborator

nanxstats commented Dec 3, 2021

It looks like the R CMD check workflow
https://github.com/Merck/r2rtf/blob/master/.github/workflows/R-CMD-check.yaml

is outdated compared to the latest version
https://github.com/r-lib/actions/blob/master/examples/check-standard.yaml

Please update the workflow and rerun the checks.

(Actually, all workflows are outdated, please update them all.)

@nanxstats
Copy link
Collaborator

nanxstats commented Dec 4, 2021

@elong0527 -you can merge this now. It is better that I send a separate PR later.

@elong0527 elong0527 merged commit 8a60daa into master Dec 4, 2021
@nanxstats nanxstats deleted the libreoffice branch October 6, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants