New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only merge if all required reviewers approved a PR #66

Closed

jd opened this issue Jul 4, 2018 · 0 comments

Labels

Member

jd commented Jul 4, 2018

Stolen from isaacs/github#1205:

I would like to have a flag on the repo that when enabled requires all assigned reviewers to approve the PR before it can be merged.

We are currently using the specific number of reviews required, but this is too rigid for our workflow. For us, the number of reviewers required depends on what was touched by the PR.

We have automation that assigns the necessary reviewers to our PRs. Having a simple check that required all assigned reviewers to approve the PR is the last piece of our workflow puzzle.

jd added the enhancement label

jd mentioned this issue

V2 Questions #232

Closed

edahlseng mentioned this issue

Added requested-reviews-approved condition #254

Merged

jd closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment