Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concatenation of changes is not robust enough #174

Closed
wonder-sk opened this issue Jun 15, 2022 · 0 comments · Fixed by #193
Closed

Concatenation of changes is not robust enough #174

wonder-sk opened this issue Jun 15, 2022 · 0 comments · Fixed by #193
Assignees
@PeterPetrik
Labels
bug Something isn't working

Comments

@wonder-sk
Copy link
Contributor

There are some cases when concatenation of changes may fail badly with a crash if the input is not well formed.

In some of those cases geodiff only reports some warnings, but if the input is invalid, we should fail early with an error rather than suceeding with a warning (that could get ignored).

ping @varmar05 or @wonder-sk for some sample data...
@wonder-sk wonder-sk added the bug Something isn't working label Jun 15, 2022
@PeterPetrik PeterPetrik self-assigned this Jan 4, 2023
@PeterPetrik PeterPetrik mentioned this issue Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterPetrik PeterPetrik

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix concat in reverse order crash MerginMaps/geodiff
2 participants
@wonder-sk @PeterPetrik