Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressions evaluation fixes #2418

Merged
merged 7 commits into from
Dec 8, 2022
Merged

Expressions evaluation fixes #2418

merged 7 commits into from
Dec 8, 2022

Conversation

alexbruy
Copy link
Contributor

@alexbruy alexbruy commented Nov 30, 2022

Fixes various issues with expressions evaluation:

@tomasMizera
Copy link
Collaborator

It probably fixes #1756 too, right @alexbruy ?

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! 🚀 Great job @alexbruy in finding all of these scenarios

app/qml/map/RecordingTools.qml Outdated Show resolved Hide resolved
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We now need to wait for some testing from @jozef-budac or @PatrikMizera

@tomasMizera
Copy link
Collaborator

Verified on test projects! 🎉

@tomasMizera tomasMizera merged commit 98584cb into master Dec 8, 2022
@tomasMizera tomasMizera deleted the expressions-evaluation branch December 8, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants