Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Port to 1.20 #44

Open
Phoupraw opened this issue Aug 5, 2023 · 18 comments
Open

[Request] Port to 1.20 #44

Phoupraw opened this issue Aug 5, 2023 · 18 comments
Labels
help wanted Extra attention is needed

Comments

@Phoupraw
Copy link

Phoupraw commented Aug 5, 2023

v1.19.4 can't be directly applied to 1.20.

@Meridanus
Copy link
Owner

I'm working on 1.20.
But i have an wierd unresolved bug that corrupt somehow the chunk its placed in when the XP Obelisk got placed.

@Phoupraw
Copy link
Author

I'm working on 1.20. But i have an wierd unresolved bug that corrupt somehow the chunk its placed in when the XP Obelisk got placed.

StorageBlockEntity#writeNbt may put null into the compound. Is this possibly a cause?

@Meridanus
Copy link
Owner

Meridanus commented Aug 23, 2023

I checked the NBT data. it*s fine, there's no null.

@Nullable
    @Override
    public Packet<ClientPlayPacketListener> toUpdatePacket() {
        return BlockEntityUpdateS2CPacket.create(this);
    }

causes the chunk to glitch, but without the render will not update.

@Meridanus Meridanus added the help wanted Extra attention is needed label Aug 24, 2023
@Phoupraw
Copy link
Author

I'm working on 1.20. But i have an wierd unresolved bug that corrupt somehow the chunk its placed in when the XP Obelisk got placed.

How does it corrupt chunk? I placed obelisk in my world but nothing wrong happened.

@Meridanus
Copy link
Owner

Breaking a block leaves ghost blocks behind and the xp_obelisk text does not update when the value changes. If you check the block value with the inspector all values correct. So the render/sync stuff goes bad.

@Phoupraw
Copy link
Author

Make StorageBlockEntity#toUpdatePacket return null will fix the corruption, but the hovering text will still not update.

@Meridanus
Copy link
Owner

Exactly. that's my current point that i'am struggling with.

@Nitjsefnie
Copy link

Any update on this?

@Phoupraw
Copy link
Author

Any update on this?

I am trying rewriting it.

@Phoupraw
Copy link
Author

@Nitjsefnie
Copy link

Any update on this?

https://github.com/Phoupraw/XpObelisk/releases/tag/v0.5.0%2B1.20.1

Your repository is marked as private

@Phoupraw
Copy link
Author

Any update on this?

https://github.com/Phoupraw/XpObelisk/releases/tag/v0.5.0%2B1.20.1

Your repository is marked as private

Oh, sorry. Now it is public.

@Nitjsefnie
Copy link

Nitjsefnie commented Dec 25, 2023 via email

@Phoupraw
Copy link
Author

Why is this not a fork and doesn't share commit history?

Because it almost doesn't inherit any code.

@Meridanus
Copy link
Owner

That's very interesting, maybe I have to do the same thing and try a complete new one.
Is it possible to see how you did it?

Do you use some new 1.20 network specific stuff?

@Phoupraw
Copy link
Author

That's very interesting, maybe I have to do the same thing and try a complete new one. Is it possible to see how you did it?

Do you use some new 1.20 network specific stuff?

I open it in my repo, as the link above.

I didn't use any new 1.20 network specific stuff. Actually, I just copied code from yours and modified them to pass compile, though the modification is a bit too many. Fortunately it works normally, but therefore I completely have no idea why it doesn't work previously: I didn't change the sync code.

@Meridanus
Copy link
Owner

That's very interesting, maybe I have to do the same thing and try a complete new one. Is it possible to see how you did it?

Do you use some new 1.20 network specific stuff?

I open it in my repo, as the link above.

I didn't use any new 1.20 network specific stuff. Actually, I just copied code from yours and modified them to pass compile, though the modification is a bit too many. Fortunately it works normally, but therefore I completely have no idea why it doesn't work previously: I didn't change the sync code.

Thank you very much. Hopefully I can provide the 1.20 version soon.

@MJRamon
Copy link

MJRamon commented Jun 30, 2024

That's very interesting, maybe I have to do the same thing and try a complete new one. Is it possible to see how you did it?

Do you use some new 1.20 network specific stuff?

I open it in my repo, as the link above.
I didn't use any new 1.20 network specific stuff. Actually, I just copied code from yours and modified them to pass compile, though the modification is a bit too many. Fortunately it works normally, but therefore I completely have no idea why it doesn't work previously: I didn't change the sync code.

Thank you very much. Hopefully I can provide the 1.20 version soon.

Any news on 1.20.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants