Update to Lazarus 1.8RC5. #410
Conversation
| @@ -101,7 +101,8 @@ TFunctionListFrame = class(TFrame) | |||
| implementation | |||
|
|
|||
| uses | |||
| SimbaUnit, Graphics, stringutil, simpleanalyzer, v_ideCodeParser, lclintf, dynlibs; | |||
| SimbaUnit, Graphics, stringutil, simpleanalyzer, v_ideCodeParser, lclintf, | |||
| dynlibs, LazFileUtils; | |||
There was a problem hiding this comment.
LazUTF8 needs to go here, correct?
There was a problem hiding this comment.
No. The modifications compile as they are. I only added the new unit when there were errors and didn't end up adding it in some files I expected to add it to. The changes were fairly complicated and I am not exactly sure why some functions were moved.
There was a problem hiding this comment.
If we used the UTF8 functions in this file before it will need LazUTF8 now.
Just because it compiles, doesn't mean it is correct.
There was a problem hiding this comment.
Really any unit that uses non-hardcoded file access should have it.
Especially any units used to give scripts access to file handling.
There was a problem hiding this comment.
The default types of keywords changed, and the type system should be ensuring that the proper functions are being used. It is not always necessary to use special UTF8 functions and some of the Lazarus 1.8 updates made changes in this vein.
Later units mask earlier ones. Some functions in FileUtils will mask the functions in LazUTF8 and LazFileUtils. I encountered this in a few places, I think this is one. Some of the imports might be redundant. Separate PRs to refactor the imports might be good to ask for, as well as other tidying-up.
This is also a response to your comment below. Some units have ordering requirements, but I didn't find any between those two.
| @@ -581,6 +586,8 @@ implementation | |||
| uses | |||
| lclintf, | |||
| syncobjs, // for the critical sections / mutexes | |||
| LazUTF8, | |||
There was a problem hiding this comment.
If I remember correctly, LazUTF8 has to be after LazFileUtils.
|
Merged into fpc-3.0 |
|
Also - thanks! |
The Lazarus 1.8RC5 release has very few breaking changes. 1.8 nears release, and it seems wise to focus development efforts on this milestone.
There are a number of
FIXMEitems in the code stemming from upstream changes to the LCL.