Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Add label support for alt and loop #41

Closed
asampal opened this issue Sep 22, 2017 · 9 comments
Closed

[request] Add label support for alt and loop #41

asampal opened this issue Sep 22, 2017 · 9 comments

Comments

@asampal
Copy link

asampal commented Sep 22, 2017

It would be nice to have cases and loops show the name provided in the source.

@vstirbu
Copy link
Collaborator

vstirbu commented Sep 22, 2017

Can you provide more details about the situation? Is this happening in mermaid preview mode or in the build-in markdown viewer? Also an example and a screenshot would be nice. Thanks!

@asampal
Copy link
Author

asampal commented Sep 23, 2017

Sure, you can see the way alt and loop should look (along with the source) when labeled, here. The plugin currently doesn't display labels. If you can add these labels, please include them for "opt" as well.

image

@vstirbu
Copy link
Collaborator

vstirbu commented Sep 23, 2017

Ok, so for this diagram:

sequenceDiagram
foo->>bar: hello
alt good
  bar->>foo: everything's cool
else bad
  bar->>foo: uh oh
end
loop keep doing it!
  foo->>baz: do it!   
end
Loading

I'm getting the following results:

screen shot 2017-09-23 at 6 35 37

screen shot 2017-09-23 at 6 37 07

The caption text is black in the dark theme.

@asampal
Copy link
Author

asampal commented Sep 23, 2017

Yup, that's what I'm using - I guess I should've looked harder. It really is close to invisible on my monitor. Could this be changed?

@vstirbu
Copy link
Collaborator

vstirbu commented Sep 24, 2017

I'll notify upstream.

@ghost
Copy link

ghost commented Feb 14, 2018

Has there been any progress on this issue?

@vstirbu
Copy link
Collaborator

vstirbu commented Feb 14, 2018

The solution should come from mermaid itself due to the way it handles the CSS.

You might speed things up by commenting on the mermaid issue referenced above.

@DesHorsley
Copy link

Hi @vstirbu looks like the upstream issue has been closed, will that solution filter down to the plugin?

@vstirbu
Copy link
Collaborator

vstirbu commented May 31, 2018

The issue was not completely fixed upstream, but the api has been extended to allow custom CSS. In the end the custom css for dark theme should be incorporated upstream, although for now we do it here.

.loopText tspan { 
   fill: inherit;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants