Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to center stopped working correctly in KDE Plasma 5.27.3 #3

Closed
denilsonsa opened this issue Apr 4, 2023 · 7 comments
Closed
Assignees

Comments

@denilsonsa
Copy link
Contributor

denilsonsa commented Apr 4, 2023

When using a mix of display resolutions and orientations, the "move to center" doesn't work correctly anymore. At best, the window position will be off center. At worst, it will be outside the visible area (i.e. in the dead area above the left-most display in the next picture).

This happens on any action that calculates the center position (either vertically or horizontally or both).

Screenshot_20230404_095735

When I used only the two vertical displays, the bug seemed gone.

This is a regression, it's new to this KDE Plasma version 5.27.3, recently made available for Manjaro users.

It is likely this is an upstream bug. I'm not sure yet, and also not sure to which module I should report it. (EDIT: I went ahead and reported it to KDE.)

It's also possible that for some unknown reason this is a transient bug that can go away after I reboot. I don't know this yet, I wanted to report this bug as soon as I found it.

@Merrit
Copy link
Owner

Merrit commented Mar 22, 2024

Hey, sorry about the delay - no idea how I wasn't notified of this issue.

There have been several changes related to this sort of code, and now the script has been further migrated to Plasma 6. Is this still an issue for you?

@Merrit Merrit self-assigned this Mar 22, 2024
@denilsonsa
Copy link
Contributor Author

I haven't upgraded the script to the latest version because I'm afraid it might not work on Plasma 5.27.11.

Also, for the past months I have not used a multi-monitor setup that has a hole. And I don't have time to test it right now. Maybe next week I can try, but it would also be appreciated if you could try reproducing it yourself. But I know it was an issue even after rebooting.

@Merrit
Copy link
Owner

Merrit commented Mar 23, 2024

I use multiple displays with different resolutions, but they don't rotate. I haven't noticed any issue like this for some time, myself.

v1.0.2 is the latest version that supports Plasma 5, versions after that only support Plasma 6.

@Merrit
Copy link
Owner

Merrit commented Apr 6, 2024

I'm going to close this for now since I can't reproduce it, but if you experience the issue again feel free to reopen! :)

@Merrit Merrit closed this as completed Apr 6, 2024
@denilsonsa
Copy link
Contributor Author

I finally had some time, and I decided to give it a try.

If I update it using Discover or the built-in KDE/Plasma "Get New Scripts" dialog, it will install v1.1.1 which only works for Plasma 6 and doesn't work on Plasma 5. I don't know why, I did not investigate.

Then, I manually replaced the contents of ~/.local/share/kwin/scripts/movewindow/* with the contents of v1.0.2. I disabled the plugin, hit Apply, closed the settings manager, opened it again, re-enabled the plugin, hit apply. Now I know for sure the 1.0.2 version is running. (Although it claims to be v1.0.0 because you accidentally forgot to update the version in the metadata file, oops!). And now it seems to work fine.

So, I believe it's fixed now. Thanks! Maybe worth making sure people will download the right version for their desktop from the KDE store, but I'll leave this up to you.

@Merrit
Copy link
Owner

Merrit commented Apr 7, 2024

Great, thanks for confirming!

Although it claims to be v1.0.0 because you accidentally forgot to update the version in the metadata file, oops!).

Yeah, oops! 😅

As for preventing the update to a non-supported version, I don't see any way to do so sadly - the script metadata doesn't have a field to specify which versions of KWin it supports, and the Pling store doesn't have a way to do so either. A big oversight for both of them, and I don't see any way I can prevent automatic updates until it is resolved in one of those 2 places. :/

@Merrit
Copy link
Owner

Merrit commented Apr 7, 2024

I added it to my to-do list for my KDE Developer tasks, when I have some time will look into adding such a field to the KWin scripting API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants