-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Powershell shows via toggle_active_window.exe #160
Comments
By adding I have been combing through the code trying to find out how It is strange to me, the |
Can you confirm which version of Nyrna you have? The dedicated toggle executable was replaced with the built-in hotkey in v2.5.0 and the latest version is currently v2.11.1. If you are using a newer version but still seeing those executables, I wonder if they didn't get cleaned up for some reason during an upgrade.. |
This is a good question as to what version I have. I downloaded it a few weeks ago, but the settings>info I'm not sure if the exe info version is reported correctly as they not often are or how I ended up with such an old version. I will redownload and install the latest version then report back if that was the issue. |
The version I downloaded a few weeks ago must have been a much older version for some reason. I installed the latest v2.11.1 and now the settings have additional options and the hotkey works without the companion app. Now I feel like a dunce, after all that time digging through the code and trying to figure out how to resolve issue, it was down to me having an old version. |
Happens to us all! I do very much appreciate the effort you made to track down the issue, and your well-crafted issue report. Thanks for contributing! ❤️ Let me know if you have any further issues. 🎉 |
Issue:
When using Nyrna Hotkey and the hotkey is pressed, a empty powershell window is briefly displayed.
Reproduce Issue:
Using Windows, run Nyrna Hotkey and press the Pause key while a target program has focus.
Investigation:
The powershell only shows when using
toggle_active_hotkey.exe
that callstoggle_active_window.exe --toggle
This does not happen when toggled via the
nyrna.exe
gui.The command line of the powershell process
powershell -NoProfile $process=[System.Diagnostics.Process]::GetProcessById(//$pid//) ; $threads=$process.Threads ; "$threads | select Id,ThreadState,WaitReason"
Expected results:
No powershell console being displayed when pause/resume a program.
Where the console process is created with the SW_HIDE flag being set like in the wWindMain of windows>runner>main.cpp
Related code in question:
nyrna/lib/native_platform/src/process/repository/src/win32_process_repository.dart
Lines 67 to 78 in 53aeee1
The text was updated successfully, but these errors were encountered: