Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues for windows users due to dependency on wcwidth #12

Open
BinderDavid opened this issue Oct 11, 2022 · 5 comments
Open

Issues for windows users due to dependency on wcwidth #12

BinderDavid opened this issue Oct 11, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@BinderDavid
Copy link

One of our Windows users is reporting problems due to the dependency on wcwidth. I have reported the problem upstream: solidsnack/wcwidth#7

I am currently investigating a solution to the problem

@Mesabloo
Copy link
Owner

Thanks for the issue!

From the issue you opened in solidsnack/wcwidth#7, this is a problem that we already faced in #11 (comment).
The version of wcwidth which is on Hackage (0.0.2) unfortunately does not bundle the pure Haskell implementation (see solidsnack/wcwidth#3 which came after the release of the version 0.0.2). Unfortunately, there is nothing I can do to fix this, other than just copy the source of the package inside this one (which I'd rather not, ideally).
The pure Haskell implementation has been rewritten in solidsnack/wcwidth#6 but we also found a bug in #11 (comment) where a single space character does not have the correct width (0 instead of 1). This was meant to be fixed but I don't think it was yet.

@Mesabloo Mesabloo added the bug Something isn't working label Oct 11, 2022
@BinderDavid
Copy link
Author

Thanks for the quick reply (and the great library). I didn't think about looking into the other issue. But apparently the solution is for upstream wcwidth to release a new version to Hackage, and to then adjust the lower bounds in diagnose accordingly. Right?

@Mesabloo
Copy link
Owner

As long as the width of the space character is patched, then yes this should be the thing to do to make it work.
The bounds on wcwidth should already be relaxed enough to account for any update which does not go beyond 1.0.0, but we'll see if it needs an update.

@aboeglin
Copy link

Does it mean that diagnose does not work on windows currently?

@Mesabloo
Copy link
Owner

See this comment: #13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants