Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bumping dependencies / GHC version #18

Open
luc-tielen opened this issue Feb 26, 2023 · 2 comments
Open

Consider bumping dependencies / GHC version #18

luc-tielen opened this issue Feb 26, 2023 · 2 comments

Comments

@luc-tielen
Copy link
Contributor

In my fork of this repo, I bumped text and hashable to newer versions.
It seems to compile and work in my compiler, so maybe worth the time to upgrade?

You can find the commit here: 98653e2

@Mesabloo
Copy link
Owner

Mesabloo commented Mar 1, 2023

Thanks for the issue.

I do not quite understand the point of restricting the version range downwards.
For example, all the code works great with say text v1. While this may be an old version, perhaps some people are still using it.
As for the upwards bump, if it fully compiles with text v2.* then I'm all for it!
And for the version of GHC used in local development, I guess this could be bumped one way or another without harming the codebase. Most of it is standard Haskell 2010 anyway (without much use of extensions...yet).

@luc-tielen
Copy link
Contributor Author

You're right, not strictly necessary. It was made in a hurry while checking if this change worked. :)
Feel free to modify the diff as you want, but atleast you now know it is possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants