How to hide the AvatarView with v1.0.0 #674

janweinkauff · 2018-05-05T05:57:00Z

I'm trying to hide the AvatarView with the new changes of 1.0.0-beta.1.

Right now I use avatarView.isHidden = true in MessagesDisplayDelegate.configureAvatarView which only hides the view but will not remove the space of the AvatarView due to the size from outgoingAvatarSize or incomingAvatarSize of MessageSizeCalculator.

Is it possible to change the value of outgoingAvatarSize or incomingAvatarSize?

I couldn't find any delegate callback or entry point for a subclass.

The text was updated successfully, but these errors were encountered:

janweinkauff · 2018-05-05T05:58:51Z

After a short chat in the slack channel I found a solution based on the suggestion from @creyD.

outgoingAvatarSize or incomingAvatarSize are just properties of the MessagesCollectionViewFlowLayout .

if let layout = messagesCollectionView.collectionViewLayout as? MessagesCollectionViewFlowLayout {
  layout.textMessageSizeCalculator.outgoingAvatarSize = .zero
  ...
}

Faisal0sal · 2018-05-05T08:09:19Z

if let layout = messagesCollectionView.collectionViewLayout as? MessagesCollectionViewFlowLayout {
layout.textMessageSizeCalculator.outgoingAvatarSize = .zero
layout.textMessageSizeCalculator.incomingAvatarSize = .zero
}

doing this in viewdidload ^^ still gave me an avatar on outgoing messages

janweinkauff · 2018-05-05T08:29:41Z

I also did this change in the viewDidLoad method. It works on my side.

Did you check if the cast messagesCollectionView.collectionViewLayout as? MessagesCollectionViewFlowLayout succeeds?
Maybe set a breakpoint to MessageSizeCalculator.avatarSize(for message:) to understand from what change the incomingAvatarSize is set?

Faisal0sal · 2018-05-05T08:32:19Z

it works now, just moving it to the bottom of my viewDidLoad did it. not sure how this affect it.

Faisal0sal · 2018-05-05T08:45:00Z

Actually although this does work on text messages, once you start loading more messages it starts to flounder between having it and removing it. It also appears on media messages.

janweinkauff · 2018-05-05T08:51:10Z

You can also set the avatar size for all other kind of messages. Please have a look into MessagesCollectionViewFlowLayout.

To change the avatar size you do same as desribed but with a different MessageSizeCalculator:

attributedTextMessageSizeCalculator.outgoingAvatarSize = .zero
emojiMessageSizeCalculator.outgoingAvatarSize = .zero
photoMessageSizeCalculator.outgoingAvatarSize = .zero
videoMessageSizeCalculator.outgoingAvatarSize = .zero
locationMessageSizeCalculator.outgoingAvatarSize = .zero

Faisal0sal · 2018-05-05T10:43:53Z

It still flounders

SD10 · 2018-05-05T12:10:21Z

@Faisal0sal keep in mind cells are reused

_{Sent with GitHawk}

ljs19923 · 2018-05-07T14:06:20Z

Do you know why i get this error ?

SD10 · 2018-05-07T14:08:17Z

@JulienLevallois I'm not sure exactly. What is your MessageKit version? Have you tried clearing derived data folder?

ljs19923 · 2018-05-07T14:13:07Z

My version is 0.13.0 and yes i deleted this folder

ljs19923 · 2018-05-07T14:16:25Z

I need to update to 0.13.5 or 1.0.0-beta.1 ?

Because with pod 'MessageKit' and pod install i got this version 0.13.0

@SD10

SD10 · 2018-05-07T14:26:54Z

You need 1.0.0-beta.1
Run pod repo update, then pod install

ljs19923 · 2018-05-07T15:45:54Z

I got this error :/

[!] Failed to connect to GitHub to update the CocoaPods/Specs specs repo - Please check if you are offline, or that GitHub is down

Faisal0sal · 2018-05-07T16:12:48Z

pod 'MessageKit', '~> 1.0.0-beta.1'

This is what worked for me.

ljs19923 · 2018-05-07T16:47:49Z

How can i verticaly align the avatar bottom with the cell in this new version ? 1.0.0-Beta.1

cwalo · 2018-05-07T16:55:51Z

@JulienLevallois Please create a separate issue for your question. Thanks!

ljs19923 · 2018-05-07T16:59:47Z

When i send a new message the outgoingAvatarSize = .zero didn't works

jaunesarmiento · 2018-05-09T05:14:57Z

Tried setting the avatar size using the following but I'm still getting blank spaces in the avatar area.

override func viewDidLoad() {
  super.viewDidLoad()

  // some code here

  if let layout = messagesCollectionView.collectionViewLayout as? MessagesCollectionViewFlowLayout {
    layout.textMessageSizeCalculator.outgoingAvatarSize = .zero
    layout.textMessageSizeCalculator.incomingAvatarSize = .zero
  }
}

What am I missing?

SD10 · 2018-05-09T05:44:36Z

@jaunesarmiento because each case of MessageKind enum has its own CellSizeCalculator object as a property of MessagesCollectionViewFlowLayout. Look at the other properties in the class and set those to zero as well if you'd like

jaunesarmiento · 2018-05-09T05:52:14Z

Ah! @SD10 silly me. Thanks for pointing it out.

ndonald2 · 2018-05-09T21:14:04Z

@SD10 it would be nice to somehow be able to set avatar sizes for all calculators at once rather than having to set size on each calculator individually, for convenience's sake. Do you think there's a place for that in the 1.0 API?

SD10 · 2018-05-09T23:29:08Z

@ndonald2 Maybe 🤔 The maintenance burden for that would be lightweight but I dislike expanding the API surface area with something a user could do themselves. We would have to also look at a convenience method for the other calculator properties as well.

ljs19923 · 2018-05-10T13:52:21Z

I removed Avater view but how can i align my bottom date to the right ? without avatar.
Thanks

ndonald2 · 2018-05-10T14:18:57Z

@SD10

I dislike expanding the API surface area with something a user could do themselves

I totally agree, but as you mentioned the maintenance cost for this would be quite low. In my opinion it seems like a very common use case to just want to change MK's default avatar size, which for both outgoing and incoming messages across all message types is currently extremely verbose:

layout.textMessageSizeCalculator.incomingAvatarSize = avatarSize
layout.textMessageSizeCalculator.outgoingAvatarSize = avatarSize
layout.attributedTextMessageSizeCalculator.incomingAvatarSize = avatarSize
layout.attributedTextMessageSizeCalculator.outgoingAvatarSize = avatarSize
layout.videoMessageSizeCalculator.incomingAvatarSize = avatarSize
layout.videoMessageSizeCalculator.outgoingAvatarSize = avatarSize
layout.photoMessageSizeCalculator.incomingAvatarSize = avatarSize
layout.photoMessageSizeCalculator.outgoingAvatarSize = avatarSize
// ... etc for all message types

That's not to say that users couldn't just create an extension to do this, but if the maintenance cost is indeed low, why not just add to the API for a better dev experience?

ljs19923 · 2018-05-10T14:58:48Z

@ndonald2 do you how can i am align the bottom date to the right ? Without avatars

SD10 · 2018-05-10T15:19:22Z

@JulienLevallois please keep all discussions on topic

_{Sent with GitHawk}

ljs19923 · 2018-05-10T19:58:49Z

Its on the topic.. its about the avatar view

nathantannar4 · 2018-05-11T22:57:16Z

@JulienLevallois Take a look at func cellBottomLabelAlignment(for message: MessageType, at indexPath: IndexPath, in messagesCollectionView: MessagesCollectionView) -> LabelAlignment . This is shown in the example project, please take a good look at it as I think it would help for a lot of your questions.

Artheyn · 2018-05-24T07:25:53Z

@JulienLevallois @SD10 , I've faced the same issues exposed by Julien and I've pushed a PR to fix this: #699

stale · 2018-06-14T20:22:32Z

This issue has been marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale · 2018-06-21T20:24:20Z

This issue has been auto-closed because there hasn't been any activity for at least 21 days. However, we really appreciate your contribution, so thank you for that! 🙏 Also, feel free to open a new issue if you still experience this problem 👍.

commando24 · 2018-06-28T11:10:23Z

Now your can use
func avatarSize(for message: MessageType, at indexPath: IndexPath, in messagesCollectionView: MessagesCollectionView) -> CGSize { return .zero }
to hide avatar.

Artheyn · 2018-06-29T07:23:48Z

Thanks for your reply @commando24 . In fact, this method has been deprecated since MessageKit 1.0:

    func avatarSize(for message: MessageType, at indexPath: IndexPath, in messagesCollectionView: MessagesCollectionView) -> CGSize {
        fatalError("avatarSize(for:at:in) has been removed in MessageKit 1.0.")
    }

But if you use the latest beta 1.0.0-beta.2 the issue is fixed (by #716).

You can now directly use :

private func setupCollectionView() {
    guard let flowLayout = messagesCollectionView.collectionViewLayout as? MessagesCollectionViewFlowLayout else { return }

    flowLayout.attributedTextMessageSizeCalculator.outgoingAvatarSize = .zero
    flowLayout.attributedTextMessageSizeCalculator.incomingAvatarSize = .zero
}

n13 · 2019-06-09T04:07:25Z

I should probably have checked this thread first. I was implementing the old delegate methods, and noticed they never get called. Duh. Ok. Then eventually found what @Artheyn said above.

guard let flowLayout = messagesCollectionView.collectionViewLayout as? MessagesCollectionViewFlowLayout else { return }

flowLayout.attributedTextMessageSizeCalculator.outgoingAvatarSize = .zero
flowLayout.attributedTextMessageSizeCalculator.incomingAvatarSize = .zero

matsotaa · 2020-08-10T15:32:22Z

Hey! nice pod)
I've got a problem, when I hide avatars in configureAvatarView:
when I type there
if let layout = messagesCollectionView.collectionViewLayout as? MessagesCollectionViewFlowLayout { layout.textMessageSizeCalculator.outgoingAvatarSize = .zero layout.textMessageSizeCalculator.incomingAvatarSize = .zero }

and if in func messageReceived I typed messagesCollectionView.scrollToBottom(animated: true) then.. in the moment when I entered in any chat, which have more messages than screen able to show scrollToBottom performs, but after it scrolls back to top.
How can I stop this scrolling(to top)

le-hu-dev · 2021-03-03T20:31:44Z

messagesCollectionView.messagesCollectionViewFlowLayout.setMessageOutgoingAvatarSize(.zero)
it works.
messageKit 3.4.1

SD10 added the question label May 5, 2018

Artheyn mentioned this issue May 24, 2018

👻Fix avatar view layout and message top/bottom label insets #699

Closed

stale bot added the stale label Jun 14, 2018

stale bot closed this as completed Jun 21, 2018

How to hide the AvatarView with v1.0.0 #674

How to hide the AvatarView with v1.0.0 #674

Comments

janweinkauff commented May 5, 2018

janweinkauff commented May 5, 2018 • edited

Faisal0sal commented May 5, 2018 • edited

janweinkauff commented May 5, 2018

Faisal0sal commented May 5, 2018

Faisal0sal commented May 5, 2018

janweinkauff commented May 5, 2018 • edited

Faisal0sal commented May 5, 2018

SD10 commented May 5, 2018

ljs19923 commented May 7, 2018

SD10 commented May 7, 2018

ljs19923 commented May 7, 2018

ljs19923 commented May 7, 2018 • edited

SD10 commented May 7, 2018

ljs19923 commented May 7, 2018

Faisal0sal commented May 7, 2018 • edited

ljs19923 commented May 7, 2018

cwalo commented May 7, 2018

ljs19923 commented May 7, 2018

jaunesarmiento commented May 9, 2018

SD10 commented May 9, 2018

jaunesarmiento commented May 9, 2018

ndonald2 commented May 9, 2018

SD10 commented May 9, 2018 • edited

ljs19923 commented May 10, 2018

ndonald2 commented May 10, 2018

ljs19923 commented May 10, 2018

SD10 commented May 10, 2018

ljs19923 commented May 10, 2018

nathantannar4 commented May 11, 2018

Artheyn commented May 24, 2018

stale bot commented Jun 14, 2018

stale bot commented Jun 21, 2018

commando24 commented Jun 28, 2018

Artheyn commented Jun 29, 2018

n13 commented Jun 9, 2019

matsotaa commented Aug 10, 2020

le-hu-dev commented Mar 3, 2021

janweinkauff commented May 5, 2018 •

edited

Faisal0sal commented May 5, 2018 •

edited

janweinkauff commented May 5, 2018 •

edited

ljs19923 commented May 7, 2018 •

edited

Faisal0sal commented May 7, 2018 •

edited

SD10 commented May 9, 2018 •

edited