Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging structure is poorly designed and poorly implemented #185

Closed
benlapETS opened this issue Apr 17, 2019 · 4 comments
Closed

Logging structure is poorly designed and poorly implemented #185

benlapETS opened this issue Apr 17, 2019 · 4 comments
Labels
Design Problem hard to fix, affects design.

Comments

@benlapETS
Copy link
Contributor

benlapETS commented Apr 17, 2019

I suspect that the solution will required a long and thorough analysis, with a lot of examples, use cases and test cases. To really measure the size of the problem, I think I would need help of people using it in day to day to get feedback and idea:

  • Peter pointed out that it would be a nice to have to be able to activate/deactivate logging in a more finer granular way so we would remove a lot of noise when trying to debug a problem.
  • I encountered issues with the fact the components enable logging in different ways depending on the component and the action that seems to be random and which change during the running of the process. We then dont have a full control of what is popping out and this can be really annoying when a lot of process are running (like in the flow test). Also the log option (-l) doesnt work Cannot specify logpath (-l) from the command line #186 .
@benlapETS
Copy link
Contributor Author

#240 might be a good reference to this design problem...

@benlapETS benlapETS added the Design Problem hard to fix, affects design. label Aug 7, 2019
@petersilva
Copy link
Contributor

hey @benlapETS is this done by branch for #issue240 ( issue240_2 ) or is this something different again. just looking to understand if we can close it as part of the next release.

@benlapETS
Copy link
Contributor Author

benlapETS commented Sep 16, 2019

Let me take a look, I had 3 concerns here (despite the too generic statement about all our logging):

  • (de)activating debug in finer granular way RESOLVED
    The fun part here is that the Python logging levels are all accessible component-wise, that finally makes sarra mostly transparent to Python logging API, including our log rotation feature. For example:

subscribe/x.conf

ll debug (only debug still works too)

poll/y.conf

ll warn

sarra/z.conf

ll error

x, y, z would be totally independant and would override the default value (info) only for each specific sr component. The useful part for now is when you want to activate the debug in one component without impacting next components to be activated which was not possible before.

  • log option (-l) RESOLVED
  • stdout/stderr redirection problem RESOLVED

@benlapETS benlapETS mentioned this issue Sep 16, 2019
@petersilva
Copy link
Contributor

closing because I think you're saying it is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Problem hard to fix, affects design.
Projects
None yet
Development

No branches or pull requests

2 participants