Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__on_post__ is not called late enough, does not accurately reflect post. #190

Closed
petersilva opened this issue Apr 21, 2019 · 3 comments
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request likely-fixed likely fix is in the repository, success not confirmed yet.

Comments

@petersilva
Copy link
Contributor

when posting v03 in particular, many transformations occur to the message before it gets posted, to the point that post_log isn't much use. It's very misleading because that baseURL and relPath settings, among others are not updated at the time the plugins are called.

@petersilva
Copy link
Contributor Author

re-arranged to have on_post plugin callbacks called much later, right before the publish.
Changed the name of the publish routine to post... moving the callbacks allowed to remove duplicate code present in both sr_subscribe and sr_post so that it is only present in sr_message.py

now post_log (an on_post plugin) is called after all transformations for v03 have occurred, so the baseURL and relPath, and everything else, is set correctly.

@petersilva petersilva added bug Something isn't working enhancement New feature or request likely-fixed likely fix is in the repository, success not confirmed yet. labels Apr 22, 2019
@petersilva petersilva self-assigned this Apr 22, 2019
@petersilva
Copy link
Contributor Author

merged.

@petersilva
Copy link
Contributor Author

released in 2.19.09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request likely-fixed likely fix is in the repository, success not confirmed yet.
Projects
None yet
Development

No branches or pull requests

1 participant