Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow on sr_watch restart #202

Closed
benlapETS opened this issue May 14, 2019 · 4 comments
Closed

Stack overflow on sr_watch restart #202

benlapETS opened this issue May 14, 2019 · 4 comments
Labels
bug Something isn't working likely-fixed likely fix is in the repository, success not confirmed yet.

Comments

@benlapETS
Copy link
Contributor

2019-05-02 15:38:38,535 [INFO] sr_watch f40 01 starting
Fatal Python error: Cannot recover from stack overflow.

Current thread 0x00007faa9536d740 (most recent call first):
  File "/usr/lib/python3.6/logging/__init__.py", line 1374 in log
  File "/usr/lib/python3/dist-packages/sarra/sr_config.py", line 85 in write
  File "/usr/lib/python3.6/logging/__init__.py", line 917 in handleError
  File "/usr/lib/python3.6/logging/__init__.py", line 1000 in emit
  File "/usr/lib/python3.6/logging/__init__.py", line 1072 in emit
  File "/usr/lib/python3.6/logging/handlers.py", line 73 in emit
  File "/usr/lib/python3.6/logging/__init__.py", line 865 in handle
  File "/usr/lib/python3.6/logging/__init__.py", line 1516 in callHandlers
  File "/usr/lib/python3.6/logging/__init__.py", line 1454 in handle
  File "/usr/lib/python3.6/logging/__init__.py", line 1444 in _log
  File "/usr/lib/python3.6/logging/__init__.py", line 1374 in log
  File "/usr/lib/python3/dist-packages/sarra/sr_config.py", line 85 in write
  File "/usr/lib/python3.6/logging/__init__.py", line 917 in handleError
@petersilva
Copy link
Contributor

any more information around when this happens?

@benlapETS
Copy link
Contributor Author

benlapETS commented May 15, 2019

I caught it once but since then I couldnt reproduce and many problems occurred before I wouldnt be able to point to the root cause for now, but I still believe that the StreamToLogger redirection thing is part of the problem...

@petersilva petersilva added the bug Something isn't working label Sep 16, 2019
@petersilva
Copy link
Contributor

Is this the recursive logging thing? is this fixed already?

@benlapETS
Copy link
Contributor Author

benlapETS commented Sep 16, 2019

This was a bug caused by StreamToLogger crashing while logging to redirected output, but then trying to write the crash msg indefinitely because the same crash always occurs from the same cause. In #240 the chain of propagation of logging msg have been reversed and it should not try to relog anymore while crashing. I don't say the new way is completely bulletproof, but definitly, this one should not come back...

@benlapETS benlapETS added the likely-fixed likely fix is in the repository, success not confirmed yet. label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working likely-fixed likely fix is in the repository, success not confirmed yet.
Projects
None yet
Development

No branches or pull requests

2 participants