This repository has been archived by the owner on May 12, 2022. It is now read-only.

"Approve" confirmation says "Unlimited" even though it's not #185

Closed

tennox opened this issue May 18, 2021 · 1 comment

tennox commented May 18, 2021 •

edited

Loading

Follow-up to #38 and in specific this comment by @pi0neerpat #38 (comment) as @Gudahtt requested to open a new issue.

I encountered that MetaMask would show "Unlimited" even though I requested a specific (small) amount:

Idea: Should say "Requested Spend Limit" - and only case of the maximum uint265 amount 1.157... × 10^77 it would say "Unlimited"

The text was updated successfully, but these errors were encountered:

tennox mentioned this issue

Why allow unlimited to edit allowance? TripleSpeeder/token-allowance-checker#128

Open

1 task

Author

tennox commented May 18, 2021

I just realized that for 0 it shows correctly:

So I re-posted this issue as a Bug Report: MetaMask/metamask-extension#11125

tennox closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.