bugfix/dont modify current transactions #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching transactions from API, if a fetch and a transaction are made in in the same block we have register of, the API transaction will overwrite the one from the app.
Example
1
and transaction hash0x1
coming fromTransactionController.addTransaction
0x1
, asnormalizeTx
is generating a new id2
(random() again)2
and hash0x1
will be saved.For swaps and also if we want to know which transactions are coming from the app, is the wrong behavior because we'd like to save the original transaction with id
1
, because we have other information depending on that original transaction.So with this PR the idea would be to save local transactions first and then remote transactions, not the inverse.