Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messages to empty tothrow calls #422

Merged
merged 2 commits into from
Mar 20, 2021

Conversation

astarinmymind
Copy link
Contributor

This PR aims to remove the eslint exception involving empty tothrow messages by replacing .tothrow() calls with .tothrow('error message').

@astarinmymind astarinmymind requested a review from a team as a code owner March 20, 2021 05:38
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astarinmymind astarinmymind merged commit f6699b1 into develop Mar 20, 2021
@astarinmymind astarinmymind deleted the remove-jest-require-tothrow-message branch March 20, 2021 16:10
Gudahtt added a commit that referenced this pull request Mar 22, 2021
This requirement was added recently in #422
Gudahtt added a commit that referenced this pull request Mar 22, 2021
This requirement was added recently in #422
Gudahtt added a commit that referenced this pull request Mar 23, 2021
This requirement was added recently in #422
Gudahtt added a commit that referenced this pull request Apr 7, 2021
This requirement was added recently in #422
Gudahtt added a commit that referenced this pull request Apr 13, 2021
This requirement was added recently in #422
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants