Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename networkID property in TransactionMeta to chainId #326

Closed
rekmarks opened this issue Jan 14, 2021 · 1 comment
Closed

Rename networkID property in TransactionMeta to chainId #326

rekmarks opened this issue Jan 14, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@rekmarks
Copy link
Member

TransactionMeta.networkID should be renamed to chainId.
@rekmarks rekmarks added the bug Something isn't working label Jan 14, 2021
@rekmarks rekmarks mentioned this issue Jan 15, 2021
Merged
@Gudahtt
Copy link
Member

Gudahtt commented Mar 11, 2021

I believe this has been resolved by #349

The networkID property remains, but it now actually refers to the network ID. Both IDs were kept around to maintain backwards compatibility (at least temporarily).

@Gudahtt Gudahtt closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gudahtt @rekmarks