Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring linting pipeline in sync with module template #164

Closed
mcmire opened this issue Feb 15, 2023 · 0 comments · Fixed by #174
Closed

Bring linting pipeline in sync with module template #164

mcmire opened this issue Feb 15, 2023 · 0 comments · Fixed by #174
Assignees

Comments

@mcmire
Copy link

mcmire commented Feb 15, 2023

Our ESLint config is out of date with our other repos, and this repo is missing Prettier as well as depcheck.

  • Copy the versions of our ESLint config packages that the module template is using. If this issue is addressed before Migrate from Mocha/Chai to Jest #166 and Migrate to TypeScript #23, we would want to omit Jest and TypeScript packages.
  • Ensure that .eslintrc.js is up to date. If this issue is addressed before Migrate from Mocha/Chai to Jest #166 and Migrate to TypeScript #23, we would want to omit Jest and TypeScript-related config.
  • Add Prettier and Prettier-related packages as development dependencies, and copy .prettierrc.js from the module template
  • Ensure that all lint:* scripts in the module template are reflected in this repo.
  • Add depcheck as a development dependency, and copy .depcheckrc.json from the module template.
  • Fix lint violations caused by the upgrade. Running yarn lint:fix should automatically fix most of them, but we will need to manually fill in missing JSDocs.
@mcmire mcmire added Epic and removed Epic labels Feb 15, 2023
@mcmire mcmire changed the title Update ESLint config rules and reformat all code Bring linting pipeline in sync with module template Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants