Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - Package 'eth-sig-util' as a browser component #100

Closed
xmaysonnave opened this issue Jul 25, 2020 · 2 comments
Closed

Comments

@xmaysonnave
Copy link

Starting from th v8.0.x, Metamask-extension is able to provide a public encryption key and to decrypt content.

I tried to dynamically load the library in my browser DApp from:
https://cdn.jsdelivr.net/npm/eth-sig-util@2.5.3/index.min.js
However it appears that this package is not build as a browser friendly component (nodejs).

In my build chain I need to clone, browserified, tercerified and embed this library in my DApp in order to encrypt content with the Metamask provided public encryption key. Roughly 400KB.

Do you have any plan to package this component as a browser friendly component ?

Thanks

@xmaysonnave xmaysonnave changed the title [Feature Request] - Deliver 'eth-sig-util' as a browser component [Feature Request] - Package 'eth-sig-util' as a browser component Jul 25, 2020
@markg85
Copy link

markg85 commented Dec 6, 2021

I totally second this! (or eight based on the thumbs up).

I too was about to attempt to use this package in a browser. There are instructions for NPM/yarn (though it breaks on npm at the moment #227). But besides that, i very much like to just have a browser package. Not a monsterified bundle package of half a megabyte.

I personally find those bundle things very destructive for the web and specifically for CDN's. Their existence is to serve common libraries. If each site bundles it's whole js stack in one gigantic bundle then the purpose of CDN's becomes 0.

@mcmire
Copy link

mcmire commented Mar 11, 2022

We have no immediate plans to do this, so I'm going to close this so it doesn't clutter up the issues list. However, we are open to reconsidering this in the future. We would also take a PR to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants