-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert @metamask/keyring-api
to monorepo
#240
Comments
Could we consider moving the keyring API to the core monorepo instead, leaving the SDK here? That might be simpler than setting up a monorepo, and we wanted all of the keyring packages used by extension/mobile to be in core eventually anyway |
I'd prefer to move to a monorepo, but I'm OK with moving the API to the core monorepo until we have the capacity to work on it. A breakdown could be as follows:
And, pending verification, the dependencies would be: graph TD
keyring-api --> keyring-utils
keyring-internal-api --> keyring-api
keyring-internal-api --> keyring-utils
keyring-snap-sdk --> keyring-api
keyring-snap-sdk --> keyring-utils
keyring-snap-client --> keyring-api
keyring-snap-client --> keyring-utils
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Description
In order to improve the maintainability of this package and its consumers we should convert it into a monorepo that contains two main packages,
@metamask/keyring-snap-sdk
@metamask/keyring-api
Notes
The text was updated successfully, but these errors were encountered: