Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snaps: Document snap_getClientStatus #1118

Closed
Montoya opened this issue Feb 1, 2024 · 0 comments · Fixed by #1119
Closed

Snaps: Document snap_getClientStatus #1118

Montoya opened this issue Feb 1, 2024 · 0 comments · Fixed by #1119
Assignees
@ziad-saab
Labels
snaps Related to Snaps content. team-snaps-platform tech-writing Requires updates to documentation content.

Comments

@Montoya
Copy link
Contributor

Montoya commented Feb 1, 2024

Add reference documentation for the method and mention in other places (like the cron jobs section) that developers should check if the extension is locked to ensure that they don't attempt to do something that doesn't work when the extension is locked.

https://github.com/MetaMask/snaps/blob/3f0705442d90b65c94e09b21cf2406e8e7614e70/packages/snaps-rpc-methods/src/permitted/getClientStatus.test.ts#L4
@ziad-saab ziad-saab self-assigned this Feb 1, 2024
@ziad-saab ziad-saab mentioned this issue Feb 1, 2024
Merged
@alexandratran alexandratran added tech-writing Requires updates to documentation content. snaps Related to Snaps content. team-snaps-platform labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ziad-saab ziad-saab

Labels
snaps Related to Snaps content. team-snaps-platform tech-writing Requires updates to documentation content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document snap_getClientStatus MetaMask/metamask-docs
3 participants
@Montoya @ziad-saab @alexandratran