Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS confusables should not include the regular letter "m" #3799

Closed
serenae-fansubs opened this issue Feb 23, 2022 · 3 comments · Fixed by #3902
Closed

ENS confusables should not include the regular letter "m" #3799

serenae-fansubs opened this issue Feb 23, 2022 · 3 comments · Fixed by #3902
Labels
design-review Any feature that needs feedback from the design team type-bug Something isn't working

Comments

@serenae-fansubs
Copy link

serenae-fansubs commented Feb 23, 2022

Describe the bug
When an ENS name is entered and contains the letter "m", Metamask flags this (incorrectly in my opinion) as a confusable character. This also appears to happen to the digits "0" and "1".

Screenshots
image

To Reproduce
Enter any ENS name that contains "m", like temp.eth
Enter any ENS name that contains "0", like 0xbitcoin.eth
Enter any ENS name that contains "1", like 1bitcoin.eth

Expected behavior
Metamask should not display that "potential scam" warning when the name just has a letter m in it

In general, if a name is only comprised of "regular" characters [a-z0-9], the confusable warning message should not appear.

@serenae-fansubs serenae-fansubs added the type-bug Something isn't working label Feb 23, 2022
@serenae-fansubs
Copy link
Author

serenae-fansubs commented Feb 23, 2022

I see that this was pointed out in multiple places on the original feature, but was dismissed as "not a bug":

#2464 (comment)

@serenae-fansubs
Copy link
Author

The same thing appears to happen for the digits "0" and 1" too. Maybe other characters too.

In general, the "confusable" message should not be shown for any character [a-z0-9].

@mobularay mobularay added the design-review Any feature that needs feedback from the design team label Mar 9, 2022
@rickycodes
Copy link
Member

rickycodes commented Mar 16, 2022

hi @serenae-fansubs

m, 0 and 1 are all valid confusables. the library we're using to flag these is just pulling from a standard document: http://www.unicode.org/reports/tr39/.

here's the full list: https://unicode.org/Public/security/10.0.0/confusables.txt, you can see the m -> rn case. m gets flagged here because it's similar to rn.

image

for the 0 & 1 cases the mapping is:

"0": "O",
 "1": "l",

because 0 can be confused with O and 1 can be confused with l.

The extension does something similar:

image

I've opened #3902 in a effort to better explain why characters get flagged in ENS names (similar to what extension does). I hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-review Any feature that needs feedback from the design team type-bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants