Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Prompt camera permission #4429

Merged
merged 9 commits into from
Jun 8, 2022
Merged

[FIX] Prompt camera permission #4429

merged 9 commits into from
Jun 8, 2022

Conversation

gantunesr
Copy link
Member

Description

Currently the app doesn't prompt or display any message when the user tries to use the QR scanner but MMM is not allowed to access the camera at a OS level. This development adds an Alert so the user is aware of this condition

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

Case 1 Case 2
Case 1 Case 2

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/289

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Mobile QA board labels Jun 1, 2022
@gantunesr gantunesr requested a review from a team as a code owner June 1, 2022 01:54
@gantunesr
Copy link
Member Author

Texts updated to,

Title: Enable camera access
Description: Camera access needed to scan a QR code associated with an account address or a contract address

sethkfman
sethkfman reviewed Jun 1, 2022
View reviewed changes
ios/Podfile.lock Outdated Show resolved Hide resolved
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 1, 2022
Fatxx
Fatxx approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexHerman1
Copy link

should we write something in the prompt that advises users' against using the "scan text" feature for addresses?

@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 6, 2022
cortisiko
cortisiko approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮🦖 🌮 🦖

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jun 7, 2022
@gantunesr gantunesr merged commit d47bef4 into main Jun 8, 2022
@gantunesr gantunesr deleted the fix/prompt-camera-permission branch June 8, 2022 02:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2022
@tommasini tommasini added the release-5.3.0 Issue or pull request that will be included in release 5.3.0 label Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

@sethkfman sethkfman sethkfman approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.3.0 Issue or pull request that will be included in release 5.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gantunesr @AlexHerman1 @Fatxx @sethkfman @cortisiko @tommasini